Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change package type to es module #435

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

TomerFi
Copy link
Owner

@TomerFi TomerFi commented May 6, 2024

fixes: #400
includes: #487, #424, #423

@pull-request-size pull-request-size bot added the size: s Pull request has 10 to 30 lines label May 6, 2024
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label May 6, 2024
@TomerFi TomerFi force-pushed the dynamic-import-commitlint branch from cd27967 to fc6a8e9 Compare May 6, 2024 03:50
@pull-request-size pull-request-size bot added size: l Pull request has 100 to 500 lines and removed size: s Pull request has 10 to 30 lines labels May 6, 2024
@TomerFi TomerFi force-pushed the dynamic-import-commitlint branch from fc6a8e9 to 1f42d2b Compare May 6, 2024 04:34
@pull-request-size pull-request-size bot added size: s Pull request has 10 to 30 lines and removed size: l Pull request has 100 to 500 lines labels May 6, 2024
@TomerFi TomerFi marked this pull request as draft May 6, 2024 04:35
Copy link

stale bot commented Jun 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale Stale issue label Jun 7, 2024
@TomerFi TomerFi removed the status: stale Stale issue label Jun 7, 2024
Copy link

stale bot commented Jul 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale Stale issue label Jul 7, 2024
@TomerFi TomerFi added type: wip Work in progress and removed status: stale Stale issue status: needs review Pull request needs a review labels Jul 7, 2024
Signed-off-by: Tomer Figenblat <tomer@tomfi.info>
@pull-request-size pull-request-size bot added size: xs Pull request has less then 10 lines and removed size: s Pull request has 10 to 30 lines labels Aug 10, 2024
@TomerFi TomerFi changed the title chore: using dynamic imports for new versions of commitlint componnents chore: convert to es module Aug 10, 2024
@TomerFi TomerFi changed the title chore: convert to es module chore: change package type to es module Aug 10, 2024
@pull-request-size pull-request-size bot added size: xxl Pull request has more then 1000 lines and removed size: xs Pull request has less then 10 lines labels Aug 10, 2024
@TomerFi TomerFi force-pushed the dynamic-import-commitlint branch 4 times, most recently from 0e0d331 to 629dbfc Compare August 11, 2024 22:51
@pull-request-size pull-request-size bot added size: l Pull request has 100 to 500 lines and removed size: xxl Pull request has more then 1000 lines labels Aug 12, 2024
@TomerFi TomerFi force-pushed the dynamic-import-commitlint branch 3 times, most recently from 2bb423a to 82c23d8 Compare August 12, 2024 21:57
@pull-request-size pull-request-size bot added size: xl Pull request has 500 to 1000 lines and removed size: l Pull request has 100 to 500 lines labels Aug 12, 2024
BREAKING CHANGE: package type is not an es module instead of commonjs

Signed-off-by: Tomer Figenblat <tomer@tomfi.info>
@TomerFi TomerFi marked this pull request as ready for review August 12, 2024 22:12
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label Aug 12, 2024
@TomerFi TomerFi removed type: wip Work in progress status: needs review Pull request needs a review labels Aug 12, 2024
@TomerFi TomerFi merged commit bb75b67 into main Aug 12, 2024
7 checks passed
@TomerFi TomerFi deleted the dynamic-import-commitlint branch August 12, 2024 22:13
@auto-me-bot auto-me-bot bot added the status: merged Pull request merged label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request has 500 to 1000 lines status: merged Pull request merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESModules dependencies
1 participant