-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew error on M1 with macOS Monterey 12.3 #121
Comments
Python support was dropped from MacOS 12.3. The script is pointing at /usr/bin/python which is now kaput! I'll update if I find a decent solution. |
Is there a temporary workaround? |
I am using the following very hacky, very dirty workaround:
-#!/usr/bin/python
+#!/Users/YOUR_USERNAME/.pyenv/versions/2.7.18/bin/python2.7 Now the proper solution would be to migrate the codebase to Python3 and change the Python binary location, but I don't see that happening anytime soon unfortunately. |
I have uninstall the itermocil and now I can not install it any more... |
just in case. as this repo doesn't seem to be updated anymore, i've forked and updated for Python3: https://github.com/godbout/itermocil |
Oh, it was simply missing the parentheses on |
Nice one @AdrienPoupa - this was my approach too. But @godbout - legend. Your fork works a treat. Cheers. |
@scottluxford enjoy 💫 had to get this fixed before working on my projects. life without iTermocil is so sparkless. |
@godbout Nice job! But when I install the itermocil and use
Anyone know how to solve this? I have zero knowledge in 🐍 |
no idea sorry. zero Python here also. was not even aware that there were tests? |
you have the stack in the error log, and the error shows an issue between float and integer conversion. that should help. maybe an issue with your config, maybe some more changes to be made. strings needed utf8 encoding/decoding. possible that there's more type restrictions now. |
I found when use |
open itermocil.py file, change the code in line 236 |
nice :D do a PR! |
I would like to point out, that first of all
Otherwise it will not work. P.s. It will still throw TypeError, but hey, at least it work. :D |
ok so if no one does it i'll do it. |
huh i saw the PR made by @Leeiio only after i've made the changes :D sorry, didn't receive any notification. strange. anyways, still merged. i've made the changes necessary regarding this issue for the other layouts too. |
Nice! But I found another bug, when I use
Maybe I should talk about bugs in another place :) |
@Leeiio i'll check. maybe if you're using my fork it's best to report bugs there. |
works here. are you sure you're using the right iTermocil? if you make changes yourself in the |
@godbout Thanx, I have reinstalled the iTermocil, now everything is ok! |
@godbout thanks so much for doing this, worked like a charm. Do you have a buymeacoffee.com link or something? |
@DougThwaites if you're into Vim i built Vim Mode for macOS. license is one coffee a month: https://github.com/godbout/kindaVim.theapp and https://kindavim.app thank you! |
@godbout Not really a Vim guy but looks cool. Just chucked a few bob your way via Ko-fi, hope it'll get ya a couple of beers where you are. Also that's crazy about the sponsorship account taking so long. Good luck. |
@DougThwaites that one's on you: (hopefully i'm better at building software than i am at taking pictures.) thanks a lot. greatly appreciated! |
and of course i'll update this thread with the next beer. |
Found another solution.
|
@Lzmog Doesn't this change the default Python to 2.7.18 everywhere? Won't this break other apps? |
- Doesn't this change the default Python to 2.7.18 everywhere? - Won't this break other apps?
|
just in case, i think PyAML is needed and you should put it back, if you're removed that line. not sure if it's a Python 3.8 error. i got a fresh install from last week on 12.3 and it worked fine. Python 3.9 (latest) installed from Homebrew. |
@ruudk - I have added you. I haven't had time to maintain this for sometime now, and have reached out to a few people before to find a new maintainer without much luck. Happy if someone on this thread wants to take a wider maintainer role! :) |
@TomAnthony Thanks for your reply! My Python skills are terrible. @godbout Since you have been so helpful in this thread, would this be something for you to take on? I would be happy to offer you a few beers of coffee's 😊 |
@DougThwaites i definitely can help with making the official repo up to date. i forked before instead because the repo didn’t seem maintained anymore. for future PRs tho i don’t think i’ll have the Python skills to judge tho. PHP JS Swift here and going full Mac apps dev so Python is definitively not on the list. if it’s fine with you guys then i’m in. i will accept the liquid rewards eventually. |
@godbout That's great! We just need somebody to make it working again on Python 3. @TomAnthony Could you invite @godbout ? Thanks! |
guys. i’m in the middle of applying for my French passport renewal after being stranded on 30 square kilometers for 2.5 FUCKING YEARS. they finally sent some consulate agent, coz it’s the French presidential elections. so i’m gonna finish this off first and only then i’ll be on iTermocil. thanks 😄 |
oh also @TomAnthony. not sure how you want to handle the repo now. are you completely out or you still want to have a say? because what i usually do in my own projects is support only the two latest official language versions (usually the last one being the stable, the previous one being the security fixes and bugs updates). for iTermocil what i would do is release a v1 for Python 3 (probably 3.9) that would break for Python 2.7 most probably. like if people want iTermocil for 2.7, i guess we would need to do a versioned release in Homebrew. (like again, no knowledge of Python or the Python ecosystem here. i just know |
Let's keep it simple. When people want to run this on Python V2, they're on their own and can use an old tag. The project should just be bumped to Python V3 as that's the default Python in Brew now. |
ok. @TomAnthony any reason why this has to be installed through |
I think it's because this is not part of brew core. Just a tap, for less important projects. |
but iTermocil is important! can't we add this to homebrew-core? i've added stuff homebrew-cask but never to core or taps. not sure about their policies. thought brew taps where kinda obsolete now? |
policies here: https://docs.brew.sh/Acceptable-Formulae |
Let's first focus on fixing this, otherwise it will def never be accepted :) |
ok i've made a PR with all the changes for Python3. what's needed now is to make a release. what i'm not sure about yet is how we want to install iTermocil. i wanna add it to homebrew-core and just do a if not we may need to update @TomAnthony's brews/taps. i have no knowledge of personal taps, but it seems that one is currently outdated and would need some rework: https://github.com/TomAnthony/homebrew-brews/issues |
i've updated to Python3. code works now. at least on my machine. not sure about M1. maybe best is that people install and try and report before we do a |
@TomAnthony your brews' syntax (https://github.com/TomAnthony/homebrew-brews/tree/master/Formula) need to be updated, currently they're not working. we can help here by:
thanks. |
@godbout Didn't had my notifications set up so therefore I missed the PR. Just enabled them. @TomAnthony Please invite @godbout and @ruudk to the https://github.com/TomAnthony/homebrew-brews repo so that we can fix it there too. |
Just that it was a long time ago, and I tried to submit it to core a few times but couldn't get it accepted at the time.
Done!
Whilst I would love to stay involved, realistically I am too time poor and I don't want to hold things back. I'm happy for you to make decisions. :) I might want to be involved more again in the future, but in that case I would expect to be more of an equal collaborator rather then benevolent dictator. :) Thanks for your work on this! |
you're definitely smarter than me. it took three days to understand the doc and it seems you made the right choice. doesn't go to core.
thank you!
tbh i'm like you, barely have time (other priorities). but on any project i work the first i do is... run iTermocil 😄️ so we'll get it working at least. definitely no issue (probably would actually prefer) if you'd stay the benevolent dictator.
no worries. thanks for the amazing tool you created! |
well, computers are not that simple 😅️ i've updated the brew and iTermocil's code. now here's the thing. by default there's not Python interpreter on macOS 12.3 anymore. but once you install Xcode and the component tools, Python is installed. but it's v3.8. installing through Homebrew with so. i have no idea if the changes i've made would work on the 3 versions. plus afaik (which means nothing), we need to point to an interpreter in iTermocil's code. currently it points to so bis. which one we go for? we'll have to edit the README i assume because afaik (again), iTermocil's users will have to install Python first. i'd say easiest would be just a |
I'll have a look later. There are a lot of formulas that depend on Python 3 and then use a homebrew helper to get that specific path. |
ok, good. if you could pinpoint to something that would help. again if it was just up to me i'd hardcode to what |
ok done. i can personally install through the usual instructions from the README (added the you guys please try and report! thank you. |
The problem has been fixed, please run |
hey @ruudk thanks but you did some great work too. so back to you. where's your own ko-fi page? :D |
I'm getting this.
The text was updated successfully, but these errors were encountered: