Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single to multiple regions conversion wizard #476

Merged
merged 8 commits into from
Sep 8, 2024

Conversation

TokisanGames
Copy link
Owner

@TokisanGames TokisanGames commented Sep 2, 2024

Builds off of #374. Converts single storage resource file to multiple storage files and facilitates setup.

TODO

  • Fix wizard menu
  • Add wizard button to inspector https://x.com/passivestar_/status/1795886728646975820 if storage_dir is empty
  • Update conversion wizard in GDScript
  • Port wizard to C++
  • Rename Terrain3DStorage to Terrain3DData
  • Strip Terrain3DStorage down to convertable resource
  • Convert demo
  • Update docs

@TokisanGames TokisanGames added enhancement New feature or request big terrains Issues that need to be addressed for big terrains labels Sep 2, 2024
@TokisanGames TokisanGames self-assigned this Sep 2, 2024
@TokisanGames TokisanGames marked this pull request as draft September 2, 2024 08:49
@TokisanGames TokisanGames changed the title Convert multiple regions WIP: Convert multiple regions Sep 2, 2024
@Xtarsia
Copy link
Contributor

Xtarsia commented Sep 2, 2024

image

@Xtarsia
Copy link
Contributor

Xtarsia commented Sep 2, 2024

Instant crash with no logs:
open the artifact project, open node3d.tsn, add 1 region, change mesh size .

Posibly related: attempting to change mesh size when a very large number of regions are present causes serious lag, and even editor freezing until the mesh size change is complete.

Also: changing LOD and vertex spacing has the same effect as above.

image

@Xtarsia
Copy link
Contributor

Xtarsia commented Sep 2, 2024

attempting to add regions by clicking outside the area, and then saving:

image

@TokisanGames TokisanGames changed the title WIP: Convert multiple regions WIP: Single to multiple regions conversion wizard Sep 3, 2024
@TokisanGames TokisanGames force-pushed the convert_multiple_regions branch 2 times, most recently from ff86b85 to 2a0e75b Compare September 5, 2024 13:03
@TokisanGames
Copy link
Owner Author

The Directory setup wizard now works to upgrade an old version. Here are our alerts to begin our upgrade process. I don't think it can be any simpler than this when the user loads an old scene, and an inspector button is redundant.

  • This pops up whenever a scene w/ a 0.9.2 storage loads.
  • Console warning saying Use Terrain3D Tools / Directory Setup to upgrade
  • Scene tree Terrain3D node yellow icon says the same, any time Data Directory is empty.
  • Release notes saying the same

The popup is automatic and the old storage file is auto popuplated. All the user needs to do is specify a new directory, click ok. On save, it will write to disk.

image

@TokisanGames TokisanGames changed the title WIP: Single to multiple regions conversion wizard Single to multiple regions conversion wizard Sep 6, 2024
@TokisanGames TokisanGames marked this pull request as ready for review September 6, 2024 09:43
@TokisanGames TokisanGames force-pushed the convert_multiple_regions branch 6 times, most recently from cafa125 to 57bd304 Compare September 8, 2024 13:31
@TokisanGames TokisanGames merged commit 1e03ab2 into main Sep 8, 2024
12 checks passed
@TokisanGames TokisanGames deleted the convert_multiple_regions branch September 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big terrains Issues that need to be addressed for big terrains enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants