-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid crashing on first installation #182
Conversation
The error that makes Godot crash for me now is that it doesn't know the symbol
|
Hmm, Maybe we need to make the change in C++, as jolt does, and catch it on the first load of the extension before any gdscript loads. Here's where jolt registers with Godot This function calls register_settings(), which is where it initiates the restart This will require some exploration and experimentation with the C++. If it's getting beyond your comfort zone you could just limit this PR to the load image changes. |
So this removes the error due to the script, but it still crashes for me. Not sure if its something completely different though:
|
if ClassDB.class_exists("Terrain3DEditor"): | ||
first_run = true | ||
OS.alert("Restart the editor to use the Terrain3D plugin") | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to run every time, not the first time after installing the plugin only. Alright, let's drop this commit and just go with the first commit which partially resolves the issue by removing the errors. Later someone will look into initiating a restart before the crash via C++. Thanks.
Superseded by #196 |
Fixes #20