Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-Peer review #2

Open
zieeco opened this issue Jan 11, 2022 · 0 comments
Open

Peer-to-Peer review #2

zieeco opened this issue Jan 11, 2022 · 0 comments

Comments

@zieeco
Copy link

zieeco commented Jan 11, 2022

Hi @Team
congratulations on implementing the feature in the project, your code looks clean and very readable 💯
However, we think as a team that it still can be improved.
Please check below and refer to the links below:

  • Add the .vscode file in your .gitignore file or your can delete is because it does nothing to your project
  • Add a focus feature to your nav link so when a user clicks any link, they can see which is active
  • In order to improve web accessibility to those who are visually impaired, increase the height of your form input and button
  • To better apply the HTML5 semantic tags, it will be better to have your nav in your header tag and wrap your current body contents inside the main tag
  • Also use the arrow function to write a concise function since we're working with ES6 in your index.js file
  • According to the project requirements, your books array should not be in global scope, but in your book class

Cheers and Happy Coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant