Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Toaster 2.1.1 that supports Swift4 #36

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

championswimmer
Copy link
Contributor

No description provided.

@championswimmer
Copy link
Contributor Author

fixes #34

@farfromrefug
Copy link

@hypery2k could you please merge and release this?

@hypery2k hypery2k merged commit 76df259 into TobiasHennig:master Oct 12, 2018
@hypery2k
Copy link
Collaborator

I merged, but CI build doesn't work, tried to fix it, but wasn't able to fix it within 3 hours - so have to postpone it

@farfromrefug
Copy link

@hypery2k can i help in any way? Can we see the CI error log?

@hypery2k
Copy link
Collaborator

you can try this branch: https://github.com/TobiasHennig/nativescript-toast/tree/bugfix/ci_build
If it's getting through in travis that would help

@seaware
Copy link

seaware commented Nov 22, 2018

Is there a solution for this? I upgraded to the latest v5 NativeScript and now get warning: Swift 3 mode has been deprecated and will be removed in a later version of Xcode. Please migrate "Toaster" to Swift 4.2 using "Convert > To Current Swift Syntax…" in the Edit menu. (in target 'Toaster'). FYI NativeScript installed Toaster v2.0.4 even though I explicitly asked for 2.1.1 as a dependency.

@hypery2k
Copy link
Collaborator

as long as it‘s just a warning no problem. But for Swift 4+ compatiblity create a new issue.

But right now Toaster doesn’t support Swift 4, see
devxoul/Toaster#139

Repository owner locked as resolved and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants