Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 1.4? #15

Closed
bradmartin opened this issue Oct 25, 2016 · 12 comments
Closed

Publish 1.4? #15

bradmartin opened this issue Oct 25, 2016 · 12 comments
Assignees
Labels
Milestone

Comments

@bradmartin
Copy link

Noticed iOS support added back in with the POD, npm still at 1.3 and package.json at 1.4.

Anything you need help with to get it ready to publish the update? Let me know if you need anything.

@hypery2k
Copy link
Collaborator

currently the iOS part is failing, see #13 (comment)

@TobiasHennig
Copy link
Owner

I think it is a Swift 3 thing, but i'm unable to determine if NativeScript is able to handle this kind of pod.

@hypery2k
Copy link
Collaborator

it should be as it exports a header for objective c: https://github.com/devxoul/Toaster/blob/master/Sources/Toaster.h

@NathanWalker
Copy link

@hypery2k
Copy link
Collaborator

we are using already https://github.com/TobiasHennig/nativescript-toast/blob/master/toast.ios.js#L9, but getting:

file:///app/tns_modules/nativescript-toast/toast.js:9:17: JS ERROR Error: Value must be a Pointer.

@NathanWalker
Copy link

NathanWalker commented Oct 25, 2016

try this:

console.log(Toast);
console.log(typeof Toast);
console.log(Toast.constructor);
return Toast(NSString.stringWithString(text));

Also try:

console.log(Toast);
console.log(typeof Toast);
console.log(Toast.constructor);
return new Toast(text);   // and with NSString above (try both)

lemme know.

@hypery2k
Copy link
Collaborator

Result for variant one:

Oct 25 22:31:15 Mare-MBP angular[29963]: CONSOLE LOG file:///app/tns_modules/nativescript-toast/toast.js:9:16: function Toaster.Toast() {
            [native code]
        }
Oct 25 22:31:15 Mare-MBP angular[29963]: CONSOLE LOG file:///app/tns_modules/nativescript-toast/toast.js:10:16: function
Oct 25 22:31:15 Mare-MBP angular[29963]: CONSOLE LOG file:///app/tns_modules/nativescript-toast/toast.js:11:16: function NSObject() {
            [native code]
        }
Oct 25 22:31:15 Mare-MBP angular[29963]: 1   0x10c46b87d NativeScript::FFICallback<NativeScript::ObjCMethodCallback>::ffiClosureCallback(ffi_cif*, void*, void**, void*)
Oct 25 22:31:15 Mare-MBP angular[29963]: 2   0x10caafc3e ffi_closure_unix64_inner
Oct 25 22:31:15 Mare-MBP angular[29963]: 3   0x10cab05f2 ffi_closure_unix64
Oct 25 22:31:15 Mare-MBP angular[29963]: 4   0x10d685410 -[UIControl _sendActionsForEvents:withEvent:]
Oct 25 22:31:15 Mare-MBP angular[29963]: 5   0x10d6847df -[UIControl touchesEnded:withEvent:]
Oct 25 22:31:15 Mare-MBP angular[29963]: 6   0x10d5c4308 -[UIWindow _sendTouchesForEvent:]
Oct 25 22:31:15 Mare-MBP angular[29963]: 7   0x10d5c4c33 -[UIWindow sendEvent:]
Oct 25 22:31:15 Mare-MBP angular[29963]: 8   0x10d5919b1 -[UIApplication sendEvent:]
Oct 25 22:31:15 Mare-MBP angular[29963]: 9   0x10d59ea7d _UIApplicationHandleEventFromQueueEvent
Oct 25 22:31:15 Mare-MBP angular[29963]: 10  0x10d57a103 _UIApplicationHandleEventQueue
Oct 25 22:31:15 Mare-MBP angular[29963]: 11  0x10ef0a551 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
Oct 25 22:31:15 Mare-MBP angular[29963]: 12  0x10ef0041d __CFRunLoopDoSources0
Oct 25 22:31:15 Mare-MBP angular[29963]: 13  0x10eeffa54 __CFRunLoopRun
Oct 25 22:31:15 Mare-MBP angular[29963]: 14  0x10eeff486 CFRunLoopRunSpecific
Oct 25 22:31:15 Mare-MBP angular[29963]: 15  0x1111999f0 GSEventRunModal
Oct 25 22:31:15 Mare-MBP angular[29963]: 16  0x10d57d420 UIApplicationMain
Oct 25 22:31:15 Mare-MBP angular[29963]: 17  0x10cab044d ffi_call_unix64
Oct 25 22:31:15 Mare-MBP angular[29963]: 18  0x123b6e160
Oct 25 22:31:15 Mare-MBP angular[29963]: file:///app/tns_modules/@angular/core/bundles/core.umd.js:9319:77: JS ERROR Error: Error in app.component.html:3:23 caused by: Toast.makeText(msg).show is not a function. (In 'Toast.makeText(msg).show()', 'Toast.makeText(msg).show' is undefined)
Oct 25 22:31:15 Mare-MBP com.apple.CoreSimulator.SimDevice.DB77DE32-F440-4B2B-A693-567993AF244B.launchd_sim[28416] (UIKitApplication:org.nativescript.toastdemoapp[0x82f4][29963]): Service exited due to signal: Segmentation fault: 11


Result for variant two:

Oct 25 22:26:25 Mare-MBP angular[29562]: CONSOLE LOG file:///app/tns_modules/nativescript-toast/toast.js:9:16: function Toaster.Toast() {
            [native code]
        }
Oct 25 22:26:25 Mare-MBP angular[29562]: CONSOLE LOG file:///app/tns_modules/nativescript-toast/toast.js:10:16: function
Oct 25 22:26:25 Mare-MBP angular[29562]: CONSOLE LOG file:///app/tns_modules/nativescript-toast/toast.js:11:16: function NSObject() {
            [native code]
        }
Oct 25 22:26:25 Mare-MBP angular[29562]: 1   0x101e6e87d NativeScript::FFICallback<NativeScript::ObjCMethodCallback>::ffiClosureCallback(ffi_cif*, void*, void**, void*)
Oct 25 22:26:25 Mare-MBP angular[29562]: 2   0x1024b2c3e ffi_closure_unix64_inner
Oct 25 22:26:25 Mare-MBP angular[29562]: 3   0x1024b35f2 ffi_closure_unix64
Oct 25 22:26:25 Mare-MBP angular[29562]: 4   0x103088410 -[UIControl _sendActionsForEvents:withEvent:]
Oct 25 22:26:25 Mare-MBP angular[29562]: 5   0x1030877df -[UIControl touchesEnded:withEvent:]
Oct 25 22:26:25 Mare-MBP angular[29562]: 6   0x102fc7308 -[UIWindow _sendTouchesForEvent:]
Oct 25 22:26:25 Mare-MBP angular[29562]: 7   0x102fc7c33 -[UIWindow sendEvent:]
Oct 25 22:26:25 Mare-MBP angular[29562]: 8   0x102f949b1 -[UIApplication sendEvent:]
Oct 25 22:26:25 Mare-MBP angular[29562]: 9   0x102fa1a7d _UIApplicationHandleEventFromQueueEvent
Oct 25 22:26:25 Mare-MBP angular[29562]: 10  0x102f7d103 _UIApplicationHandleEventQueue
Oct 25 22:26:25 Mare-MBP angular[29562]: 11  0x10490d551 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
Oct 25 22:26:25 Mare-MBP angular[29562]: 12  0x10490341d __CFRunLoopDoSources0
Oct 25 22:26:25 Mare-MBP angular[29562]: 13  0x104902a54 __CFRunLoopRun
Oct 25 22:26:25 Mare-MBP angular[29562]: 14  0x104902486 CFRunLoopRunSpecific
Oct 25 22:26:25 Mare-MBP angular[29562]: 15  0x106b119f0 GSEventRunModal
Oct 25 22:26:25 Mare-MBP angular[29562]: 16  0x102f80420 UIApplicationMain
Oct 25 22:26:25 Mare-MBP angular[29562]: 17  0x1024b344d ffi_call_unix64
Oct 25 22:26:25 Mare-MBP angular[29562]: 18  0x11936e6a0
Oct 25 22:26:25 Mare-MBP angular[29562]: file:///app/tns_modules/@angular/core/bundles/core.umd.js:9319:77: JS ERROR Error: Error in app.component.html:3:23 caused by: No initializer found that matches constructor invocation.

@hypery2k hypery2k added this to the 1.4.0 milestone Oct 25, 2016
@NathanWalker
Copy link

Thanks interesting now try this:
Toast({text: 'test'})

@hypery2k
Copy link
Collaborator

It's also not working:

13  start@file:///app/tns_modules/application/application.js:234:26
14  bootstrapApp@file:///app/tns_modules/nativescript-angular/platform.js:60:26
15  bootstrapModule@file:///app/tns_modules/nativescript-angular/platform.js:53:26
16  anonymous@file:///app/main.js:19:57
17  evaluate@[native code]
18  moduleEvaluation@[native code]
19  @[native code]
20  promiseReactionJob@[native code]
JavaScript error:
file:///app/tns_modules/@angular/core/bundles/core.umd.js:9319:77: JS ERROR Error: Error in app.component.html:3:23 caused by: Value must be a Pointer.

Trying to use the NativeScript Inspector to step deeper in, but this thing is a real mess ...

@kssfilo
Copy link

kssfilo commented Nov 6, 2016

Hi, This looks working fine.

return Toast.alloc().initWithTextDelayDuration(text,0,d);

hypery2k added a commit that referenced this issue Nov 6, 2016
@hypery2k
Copy link
Collaborator

hypery2k commented Nov 6, 2016

can confirm that current version (master is working)

@hypery2k
Copy link
Collaborator

hypery2k commented Nov 6, 2016

Version 1.4.0 is out !

@hypery2k hypery2k closed this as completed Nov 6, 2016
@hypery2k hypery2k self-assigned this Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants