Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show team assigned leagues during selection #419

Open
sgurlt opened this issue Nov 8, 2021 · 5 comments
Open

Show team assigned leagues during selection #419

sgurlt opened this issue Nov 8, 2021 · 5 comments

Comments

@sgurlt
Copy link

sgurlt commented Nov 8, 2021

Hi,

in my current project, I am facing the issue that I have multiple teams having the same name, while they are assigned to different leagues.

image

image

To make the selection easier for the editors, I am going to create a patch which will add a checkbox on the Sportspress settings page "Show team assigned leagues during selection".

When the setting is enabled, the editors will see the leagues which are assigned to a team within the selection list.
Like e.g.:

  • Wiesbaden Phantoms (GFL2)
  • Wiesbaden Phantoms (AVF)
  • Wiesbaden Phantoms
  • Wiesbaden Phantoms (AFF, ADF)

I am going to start working on the pull request in about one week. Please let me know what you think about it.

Best regards,
Sebastian

@sgurlt
Copy link
Author

sgurlt commented Nov 10, 2021

#420

I have created the pull request, but it seems like I am not allowed to link it to this issue :-)

@sgurlt
Copy link
Author

sgurlt commented Nov 11, 2021

After merging the pull request and enabling the option, the selection will look like this:

image

image

@brianmiyaji
Copy link
Collaborator

@sgurlt Thanks, this is great! I'll review the pull request shortly ;)

@sgurlt
Copy link
Author

sgurlt commented Nov 24, 2021

Hi @brianmiyaji would be awesome if you could also have a look at this one when you are on it: #424

:-)

@sgurlt
Copy link
Author

sgurlt commented Mar 14, 2022

Any news on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants