Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite modules using templates #23

Open
rvolosatovs opened this issue Feb 22, 2019 · 0 comments
Open

Rewrite modules using templates #23

rvolosatovs opened this issue Feb 22, 2019 · 0 comments
Labels
technical debt

Comments

@rvolosatovs
Copy link
Contributor

rvolosatovs commented Feb 22, 2019 •
edited
Loading

Summary:

Modules at modules should be refactored to use templates (https://golang.org/pkg/text/template) instead of using strings.Builder for clarity.

What is already there? What do you see now?

strings.Builder and bunch of Write calls

What is missing? What do you want to see?

Clear templates
See https://github.com/lyft/protoc-gen-validate/tree/v0.0.13/templates for an example

How do you propose implementing this?

Rewrite implementations to use templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@htdvisser @rvolosatovs