New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete code in AIGroup::Group_Tighten_To_Position() #915

Open

xezon opened this issue May 13, 2023 · 0 comments

Labels

investigate vanilla-bug

Contributor

xezon commented May 13, 2023

Call to Get_Min_Max_And_Center appears to be obsolete.

void AIGroup::Group_Tighten_To_Position(const Coord3D *target_pos, bool append, CommandSourceType cmd_source)
{
    if (cmd_source == COMMANDSOURCE_PLAYER && g_theWriteableGlobalData->m_groupMoveClickToGatherAreaFactor > 0.0f) {
        Coord2D min;
        Coord2D max;
        Coord3D center;
        Get_Min_Max_And_Center(&min, &max, &center);
    }
...

xezon added vanilla-bug investigate labels

bobtista mentioned this issue

Removes obsolete code and adds comments in AIGroup::Group_Tighten_To_Position #937

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment