Inefficient logic in AI::CRC_Snapshot

[xezon]

Marker strings is set anew in every loop iteration unnecessarily.

void AI::CRC_Snapshot(Xfer *xfer)
{
    xfer->xferSnapshot(m_pathfinder);
    Utf8String marker;

    for (TAiData *data = m_aiData; data != nullptr; data = data->m_next) {
        marker = "MARKER:TAiData";
        xfer->xferAsciiString(&marker);
        xfer->xferSnapshot(data);
    }

    for (auto it = m_groupList.begin(); it != m_groupList.end(); it++) {
        if (*it != nullptr) {
            marker = "MARKER:AIGroup";
            xfer->xferAsciiString(&marker);
            xfer->xferSnapshot(*it);
        }
    }
}

Better:

void AI::CRC_Snapshot(Xfer *xfer)
{
    xfer->xferSnapshot(m_pathfinder);
    Utf8String marker("MARKER:TAiData");

    for (TAiData *data = m_aiData; data != nullptr; data = data->m_next) {
        
        xfer->xferAsciiString(&marker);
        xfer->xferSnapshot(data);
    }

    marker = "MARKER:AIGroup";

    for (auto it = m_groupList.begin(); it != m_groupList.end(); it++) {
        if (*it != nullptr) {
            xfer->xferAsciiString(&marker);
            xfer->xferSnapshot(*it);
        }
    }
}