Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use transparent as "no data" color (because Cesium-drawn empty circles are nearly unclickable) #799

Closed
meh9 opened this issue Jul 1, 2015 · 7 comments
Labels

Comments

@meh9
Copy link
Contributor

meh9 commented Jul 1, 2015

When adding tabular data to Cesium containing points and some lines do not have a value for whatever column is currently being visualised, then these points are drawn "empty", i.e. no colour fill. Unfortunately this makes the point very hard to click since it appears you have to click the line of the circle in order to bring up the data for that point.

The Test entry in this CSV shows the issue once dragndropped onto NM:

Some data, Place, Lat, Lon, Data1, Data2
1, NICTA,-35.2817828,149.1248208, Some more data from the CSV, And some more
4, Parkwood Road Substation,-35.2195879,148.996752, Some more data from the CSV, And some more
5, Cotter Dam,-35.3202023,148.9398087, Some more data from the CSV, And some more
,Test,-35.29,149, Some more data from the CSV, And some more
@stevage
Copy link
Contributor

stevage commented Jul 16, 2015

Closely related issue: points in GeoJSON files with marker icons are very hard to click on as well - you have to click on the very base of the signpost (not the sign itself).

@kring
Copy link
Member

kring commented Jul 18, 2015

The difficulty in clicking marker icons is caused by CesiumGS/cesium#2894.

@meh9 meh9 added the P-AREMI label Jan 28, 2016
@meh9
Copy link
Contributor Author

meh9 commented Jan 28, 2016

This has been highlighted by GA testing of AREMI. It would be nice to have this fixed, as it is a problem we just live with at the moment.

The best way to test is to turn on Electricity Inf. -> Generation -> Current Power Generation -> All in AREMI and play around clicking inside and on the edge of the unfilled circles:

http://nationalmap.gov.au/renewables/#share=0fR0dV

@stevage
Copy link
Contributor

stevage commented Feb 3, 2016

Ok, so let's reframe this issue as "Don't leave circles unfilled, even when there is no data". Then it becomes a lot simpler. At the least, we could use a very low opacity colour.

@stevage stevage changed the title Cesium drawn empty circles are nearly unclickable Don't use transparent as "no data" color (because Cesium-drawn empty circles are nearly unclickable) Feb 3, 2016
@meh9
Copy link
Contributor Author

meh9 commented Feb 3, 2016

I do like the look of having the circles empty, as that really says "no value" to me. If we can retain that look, or something like it using a a nearly transparent colour (or white?) would be great.

@RacingTadpole
Copy link
Contributor

FYI, #1250 added a nullColor option to tableStyle: "defaults to a dark blue. This colour is used to display null values (but it does not appear on the legend; we should add it). It is also used to colour points when no variable is selected."

@RacingTadpole
Copy link
Contributor

I believe this is fixed now by the addition of nullColor, replaceWithNullValues and replaceWithZeroValues.
At least the sample csv file you give above @meh9 works now, because by default missing numerical values are now shown as if zero (which makes the AREMI electricity data work nicely); you can change this to make them show as the nullColor (defaulting to black) by setting replaceWithNullValues and replaceWithZeroValues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants