feat(JOML): migrate BlockPlacingWeatherSystem #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
requested changes
Dec 31, 2020
Comment on lines
73
to
75
| Vector3i playerPos = blockPos.set(locComp.getWorldPosition(position), RoundingMode.FLOOR); | ||
|
|
||
| placeSnow(playerPos); |
There was a problem hiding this comment.
This looks like we don't need playerPos at all here:
Suggested change
| Vector3i playerPos = blockPos.set(locComp.getWorldPosition(position), RoundingMode.FLOOR); | |
| placeSnow(playerPos); | |
| blockPos.set(locComp.getWorldPosition(position), RoundingMode.FLOOR); | |
| placeSnow(blockPos); |
| * @param event The event that means it is time to place snow | ||
| * @param worldEntity The entity that sent the event (assumed to be the player) | ||
| */ | ||
| @ReceiveEvent | ||
| public void onPlaceEvent(PeriodicActionTriggeredEvent event, EntityRef worldEntity) { | ||
| final Vector3f position = new Vector3f(); | ||
| final Vector3i blockPos = new Vector3i(); |
There was a problem hiding this comment.
Is this really the blockPos or is this the "player position in block coordinates"?
skaldarnar
approved these changes
Dec 31, 2020
skaldarnar
deleted the
feature/joml-migrate-BlockPlacingWeatherSystem
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.