feat: shallower or completely dry rivers in drier areas #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
reviewed
Jul 29, 2021
There was a problem hiding this comment.
It still needs some tweaks, especially to the river biome allocation, and to make sure that it doesn't mess with other rivers too much
I guess this is something you'd like to add to this PR, right?
Haven't tested this in-game yet, will hopefully find some time tomorrow.
|
I've done a lot of testing and a couple tweaks, and I think it's more or less ready now. This does create dry canyons now, which is nice: |
skaldarnar
added
Topic: WorldGen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises the riverbed by up to
maxDepthblocks in dry areas, so that the river is shallower and sometimes doesn't have water at all. It still needs some tweaks, especially to the river biome allocation, and to make sure that it doesn't mess with other rivers too much; I'd also like canyons without water to be more common, but I'm not sure how feasible that actually is.