feat(JOML): migrate BiodiversityGenerator #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
added a commit
to Terasology/Alchemy
that referenced
this pull request
Dec 29, 2020
pollend
added a commit
to Terasology-Archived/WoodAndStone
that referenced
this pull request
Dec 29, 2020
This was referenced Dec 29, 2020
skaldarnar
reviewed
Dec 30, 2020
| @@ -5,7 +5,6 @@ | |||
| "displayName": "Genome", | |||
| "description": "Allows to define an organism type (say herbs) in a module, define the properties they have based on the DNA (genes) and this module will handle breeding organisms and their DNA changes (including mutations).", | |||
| "dependencies": [ | |||
| { "id": "AnotherWorld", "minVersion": "1.0.0" }, | |||
There was a problem hiding this comment.
👍
We need to update the module version to have the SNAPSHOT appended, though 😉
skaldarnar
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got rid of the dependency to AnotherWorld and replaced UniformNoiseAlpha with just a sigmoid function. the maximums range would be between .7 and .26 but you can scale it with an alpha value.