fixed world provider for joml changes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kBlaszczyk
requested changes
May 1, 2020
Comment on lines
181
to
184
| @Override | ||
| public boolean isBlockRelevant(Vector3f pos) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
You can remove the non read-only equivalents, they're obsolete now.
There was a problem hiding this comment.
that's a teramath vector. I think i need it from the interface and I believe its marked as depreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is addresses changes in: MovingBlocks/Terasology#3899