Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip for Chest, Furnace and TNT #7

Merged
merged 3 commits into from
May 9, 2024

Conversation

subjectnull
Copy link
Contributor

@subjectnull subjectnull commented May 6, 2024

Fixes #6

It looks like internationalisation efforts were attempted in the past but the string interpolation was not working as expected, resulting in the odd looking tooltip.

Ideally we would internationalise all display strings, however we currently only have a single string for Chest in English and German. I've used English string literals as a temporary UX improvement since that's what #6 requested, however if you'd like me to try to get internationalisation working just let me know.

This also creates a new prefab for the furnace. The optional fix under #6 suggested extracting shared props into a common base prefab, but I wasn't sure what common properties were guaranteed to be shared, if any. The furnace block has clearly been copy/pasted from the chest but these really seem like they should be used differently (chest for storage vs furnace for utility). Modifying a base prefab that alters both might be a bit of rake in the grass. Just let me know if you feel differently, happy to go in another direction if that suits!

It was surprisingly tricky to take a screenshot for evidence 😅 The game hijacks my PrtSc key, and F12 in-game screenshot functionality doesn't capture the UI. Here's a video instead:

Screencast.from.06-05-24.22.55.56.webm

Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out fine, thank you for the fix 👍

For now, fixing this issue by removing the internationalization is fine as it directly improves user experience for all users. Eventually we do want to get back to internationalization, but right now I think that topic is not our first priority.

Shared props between the two could be things like the inventory access and slots, hardness and categories, etc. Using base prefabs for similar blocks is something we do quite often and while I agree that they should be used differently from a user's perspective, that doesn't necessarily mean they are different from a technical perspective. Anyway, in this particular case I also don't see a big issue in having the two separate, so I'm fine to merge it as is 👍

Thank you for the considerate contribution! 💚

assets/blocks/furnishings/Furnace.block Outdated Show resolved Hide resolved
@jdrueckert jdrueckert merged commit 0217f54 into Terasology:develop May 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Tooltip for Chest and Furnace
2 participants