Fix tooltip for Chest, Furnace and TNT #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
It looks like internationalisation efforts were attempted in the past but the string interpolation was not working as expected, resulting in the odd looking tooltip.
Ideally we would internationalise all display strings, however we currently only have a single string for
Chest
in English and German. I've used English string literals as a temporary UX improvement since that's what #6 requested, however if you'd like me to try to get internationalisation working just let me know.This also creates a new prefab for the furnace. The optional fix under #6 suggested extracting shared props into a common base prefab, but I wasn't sure what common properties were guaranteed to be shared, if any. The furnace block has clearly been copy/pasted from the chest but these really seem like they should be used differently (chest for storage vs furnace for utility). Modifying a base prefab that alters both might be a bit of rake in the grass. Just let me know if you feel differently, happy to go in another direction if that suits!
It was surprisingly tricky to take a screenshot for evidence 😅 The game hijacks my
PrtSc
key, andF12
in-game screenshot functionality doesn't capture the UI. Here's a video instead:Screencast.from.06-05-24.22.55.56.webm