feat(JOML): migrate block networks #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
added a commit
to Terasology/Signalling
that referenced
this pull request
Dec 31, 2020
skaldarnar
requested changes
Jan 2, 2021
| public ImmutableBlockLocation(Vector3i location) { | ||
| this(location.x, location.y, location.z); | ||
|
|
||
| public ImmutableBlockLocation(Vector3ic location) { |
There was a problem hiding this comment.
Can this whole class just be removed in favor of Vector3ic?
There was a problem hiding this comment.
I can but the module doesn't really work and the way it works is very limited. I rather just make the changes to drop the dependencies to the deprecated methods.
Comment on lines
65
to
68
| public ImmutableBlockLocation move(Side side) { | ||
| final Vector3i directionVector = side.getVector3i(); | ||
| return new ImmutableBlockLocation(x + directionVector.x, y + directionVector.y, z + directionVector.z); | ||
| final Vector3ic directionVector = side.direction(); | ||
| return new ImmutableBlockLocation(x + directionVector.x(), y + directionVector.y(), z + directionVector.z()); | ||
| } |
There was a problem hiding this comment.
this is equivalent to the following, and I think we don't need a full class for this.
immutablePos.translate(side.getVector3i(), new Vector3i());
skaldarnar
approved these changes
Jan 9, 2021
skaldarnar
added a commit
to Terasology/Signalling
that referenced
this pull request
Jan 9, 2021
Adjust for changes in Terasology/BlockNetwork#15 Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module PRs