-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(JOML): migrate block networks #15
Conversation
public ImmutableBlockLocation(Vector3i location) { | ||
this(location.x, location.y, location.z); | ||
|
||
public ImmutableBlockLocation(Vector3ic location) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this whole class just be removed in favor of Vector3ic
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can but the module doesn't really work and the way it works is very limited. I rather just make the changes to drop the dependencies to the deprecated methods.
public ImmutableBlockLocation move(Side side) { | ||
final Vector3i directionVector = side.getVector3i(); | ||
return new ImmutableBlockLocation(x + directionVector.x, y + directionVector.y, z + directionVector.z); | ||
final Vector3ic directionVector = side.direction(); | ||
return new ImmutableBlockLocation(x + directionVector.x(), y + directionVector.y(), z + directionVector.z()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is equivalent to the following, and I think we don't need a full class for this.
immutablePos.translate(side.getVector3i(), new Vector3i());
Adjust for changes in Terasology/BlockNetwork#15 Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
Module PRs