Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategies for noise collection? How are max_var and min_mean set? Is there any principle? #12

Open
yanghedada opened this issue Oct 24, 2020 · 9 comments

Comments

@yanghedada
Copy link

yanghedada commented Oct 24, 2020

Hi

hi, how are max_var and min_mean set in the noise collection method? Do you have any experience and skills? When I collected it myself, I found that most of the noise pictures are white environment pictures. Is it because the sky pictures have more obvious noise? For face data max_var = 20, min_mean = 50 is appropriate?

  if opt.dataset == 'df2k':
        img_dir = PATHS[opt.dataset][opt.artifacts]['source']
        noise_dir = PATHS['datasets']['df2k'] + '/Corrupted_noise'
        sp = 256
        max_var = 20
        min_mean = 0
    else:
        img_dir = PATHS[opt.dataset][opt.artifacts]['hr']['train']
        noise_dir = PATHS['datasets']['dped'] + '/DPEDiphone_noise'
        sp = 256
        max_var = 20
        min_mean = 50

thanks for your sharing! ! !

@jolt2017
Copy link

Have the same troubles. Looking forward the author's answer

@zhangyunming
Copy link

+1
i train my face/portrait data ,the noise is to strong ,the relust is not real , seems 美颜一样。
不晓得怎么调这个noise的参数

@JingzheLyp
Copy link

I cannot collect any noise patchs from face data, have you solved it? @yanghedada

@yanghedada
Copy link
Author

The author's noise is a flat area noise. @JingzheLyp

@lxy5513
Copy link

lxy5513 commented Jan 21, 2021

I cannot collect any noise patchs from face data, have you solved it? @yanghedada

@JingzheLyp me too, have you solve the problem?

@shengbokang
Copy link

@yanghedada I did not find the noise generation code. I think the noise_collect.py just cuts the noise patch but not collects the noise. Could you please tell me where is the noise collection function? Thanks.

@ira7bar
Copy link

ira7bar commented May 5, 2021

I cannot collect any noise patchs from face data, have you solved it? @yanghedada

Depending on your data, I would try to collect noise patches without the condition of minimum patch mean. This enforces only bright flat patches (e.g. empty sky) which may not exist in your data.
Also, notice that the script uses a variance condition, as opposed to standard deviation as explained in the paper.
Moreover, it may be hard to find large empty patches, so you can try to use smaller patch sizes, which are still larger then your input low resolution size.

You can try and play with the different thresholds and see if patches are collected successfully.

It is important to visualize the resulting patches (normalize to [0,255]) and make sure that they contain only noise and not content. Otherwise, the model will learn to erase the injected content.

@Lcjgh
Copy link

Lcjgh commented Oct 27, 2022

How to select the threshold for extracting noise from uneven areas?I don't understand the selection trigger condition of this threshold.

@Lcjgh
Copy link

Lcjgh commented Oct 27, 2022

@yanghedada @ira7bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants