Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ucode support concerns #6

Open
mikehansen1970 opened this issue Feb 6, 2024 · 2 comments
Open

Ucode support concerns #6

mikehansen1970 opened this issue Feb 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mikehansen1970
Copy link
Contributor

The ucode portion of this repository is not in line with the schema and is not updated.

The README needs to be reflected to indicate this disconnect to avoid confusing potential adapters of OLS

If the ucode portion is not going to be used at all, it should probably be removed.
If the ucode portion is to be retained, then it needs to be scrubbed clean and perhaps set up to have stubs for various pieces, and removing dependence on an OpenWrt and/or other ucentral architecture.
It could somewhat resemble the plat-example in the ols-ucentral-client, because the actual implementation could be highly variable between different systems.

Additionally the schema and state definitions would do well to have the AP specific schema elements like radios, as these are not applicable for switches.

This is a significant amount of work and would perhaps be best undertaken in phases, but it is important.

@mikehansen1970 mikehansen1970 added the enhancement New feature or request label Feb 6, 2024
@Cahb
Copy link
Contributor

Cahb commented Feb 6, 2024

Thanks Mike!
That's really an important note;

Also adding Paul into CC, maybe he would have some comments and insights as well;

@phwhite FYI

@phwhite
Copy link
Contributor

phwhite commented Feb 7, 2024

Thanks @mikehansen1970 for your comments. I agree for now that we should update the README. The reason we haven't scrubbed this yet, is because I'n hoping to work with John Crispin and merge the schema changes back into a single schema for both AP and Switches. There are some complexities here, including how to handle ucode given that is an AP-only aspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants