Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes#691 twitter-bot-py #725

Closed
wants to merge 7 commits into from
Closed

Fixes#691 twitter-bot-py #725

wants to merge 7 commits into from

Conversation

okarin1511
Copy link

Fixes: #691

Explanation

Added a Twitter bot that fetches data from an api and posts anime quotes on scheduled times.

Fixes #: #691

Checklist

  • The PR title starts with "Fix #issue_number".
  • My branch is up-to-date with the main branch.
  • The PR does not contain any unnecessary auto-generated code.
  • The PR does not break any part of the existing code.
  • The PR creator have carefully read & adher to the guidelines of the project.
  • The PR is raised after the issue has been assigned to the PR creator.

@okarin1511 okarin1511 changed the title twitter-bot-py Fixes#691 twitter-bot-py Jun 23, 2021
GowthamGoush
GowthamGoush suggested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@GowthamGoush GowthamGoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider removing the changes from this project repo's readme and adding the images of your script in the readme.

GowthamGoush
GowthamGoush reviewed Jun 24, 2021
View reviewed changes
Copy link
Contributor

@GowthamGoush GowthamGoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I don't find the images being added or any changes in the main readme being removed.
So, please consider removing the changes from this project repo's readme and adding the images of your script in the readme.

GowthamGoush
GowthamGoush suggested changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@GowthamGoush GowthamGoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, nice job!
But one last thing, consider removing the changes that you've made in the readme of the main repository of this project.

GowthamGoush
GowthamGoush reviewed Jun 25, 2021
View reviewed changes
Copy link
Contributor

@GowthamGoush GowthamGoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider copy/pasting the same readme of the main repo to the readme that you've added the changes.

@GowthamGoush
Copy link
Contributor

@okarin1511, any progress?

@okarin1511 okarin1511 closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GowthamGoush GowthamGoush GowthamGoush requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Twitter-bot written in Python
2 participants
@okarin1511 @GowthamGoush