Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark & Light Mode added to existing Analog Clock #612

Closed
wants to merge 4 commits into from
Closed

Dark & Light Mode added to existing Analog Clock #612

wants to merge 4 commits into from

Conversation

ArshWalker
Copy link
Contributor

@ArshWalker ArshWalker commented Jun 18, 2021 •
edited

Explanation

I have added the Dark&Light Mode toggle button in the existing Analog Clock Script. It's changing background to dark and
light color.
Fixes #528 :

Please review it...

Checklist

  • The PR title starts with "Fix #issue_number".
  • My branch is up-to-date with the main branch.
  • The PR does not contain any unnecessary auto-generated code.
  • The PR does not break any part of the existing code.
  • The PR creator have carefully read & adher to the guidelines of the project.
  • The PR is raised after the issue has been assigned to the PR creator.

GowthamGoush
GowthamGoush suggested changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@GowthamGoush GowthamGoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @ArshWalker, could you please consider adding some snaps of these enhancements to the readme.

@RaveenaBhasin
Copy link
Contributor

@ArshWalker Are u still working on this issue?

@ArshWalker
Copy link
Contributor Author

@RaveenaBhasin Yes, I will do it by today.

@amanjha8100
Copy link
Contributor

Hey, @ArshWalker what is the update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GowthamGoush GowthamGoush GowthamGoush requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theme Clock using JS with dark and light mode
4 participants
@ArshWalker @RaveenaBhasin @amanjha8100 @GowthamGoush