add pre-commit #736
Open
add pre-commit #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would close #731 |
|
@peterbarancek have a look at this please when available... I'll back in 3 weeks 🗡️ @rruiter87 thanks a lot! |
|
Enjoy your (I guess) holidays, Peter! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some pre-commits:
dotnet tool install -g csharpierAs you can see there are a lot of changes.
You can also play around with it on your local system, if you don't check out the latest commit, because that one already has all the changes applied.
To test, ensure you have python installed and then run
pip install pre-commit. To run all the pre-commits on the project runpre-commit run --all-files. You can remove or comment out some of the pre-commit hooks to see what each one does.I've currently set the targeted Twincat version at
--target-version=3.1.4024.56in the.pre-commit-config.yaml. Not sure if this is the one you want.