[fix](fe) Fix calc cloud qps metric incorrect (apache#38874)

* When calculating qps, we should use `HashMap.put` instead of `HashMap.replace` to record last value
TangSiyang2001 · Aug 9, 2024 · 9b9deb3 · 9b9deb3
1 parent 572643a
commit 9b9deb3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/metric/MetricCalculator.java b/fe/fe-core/src/main/java/org/apache/doris/metric/MetricCalculator.java
@@ -130,7 +130,7 @@ private void updateCloudMetrics(long interval) {
                 rps = Double.max(rps, 0);
                 MetricRepo.updateClusterRequestPerSecond(clusterId, rps,  metric.getLabels());
                 MetricRepo.DORIS_METRIC_REGISTER.addMetrics(metric);
-                clusterLastRequestCounter.replace(clusterId, metric.getValue());
+                clusterLastRequestCounter.put(clusterId, metric.getValue());
             });
         }
 
@@ -142,7 +142,7 @@ private void updateCloudMetrics(long interval) {
                 rps = Double.max(rps, 0);
                 MetricRepo.updateClusterQueryPerSecond(clusterId, rps,  metric.getLabels());
                 MetricRepo.DORIS_METRIC_REGISTER.addMetrics(metric);
-                clusterLastQueryCounter.replace(clusterId, metric.getValue());
+                clusterLastQueryCounter.put(clusterId, metric.getValue());
             });
         }
 
@@ -154,7 +154,7 @@ private void updateCloudMetrics(long interval) {
                 rps = Double.max(rps, 0);
                 MetricRepo.updateClusterQueryErrRate(clusterId, rps, metric.getLabels());
                 MetricRepo.DORIS_METRIC_REGISTER.addMetrics(metric);
-                clusterLastQueryCounter.replace(clusterId, metric.getValue());
+                clusterLastQueryErrCounter.put(clusterId, metric.getValue());
             });
         }
     }