Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_exists endpoint needs to check sanitized name for folders #77

Open
susannemoog opened this issue Apr 3, 2019 · 1 comment
Open

Comments

@susannemoog
Copy link
Contributor

Currently the file_exists endpoint returns false if a folder was renamed after upload - it's working for files on top level. Examples:

file named: "2019_01_29 10_13 AM Office Lens.jpg" -> "2019_01_29_10_13_AM_Office_Lens.jpg" after upload, second upload of the same file reports "file exists"

folder named "1. Mai" becomes "1._Mai" after upload. Uploading the same folder again, the file_exists check returns false for all files in there, but the upload fails as the folder exists and can't be created again (and the override check is also missing then).

@susannemoog susannemoog added this to Backlog in DAM Sprint via automation Apr 3, 2019
@susannemoog susannemoog moved this from Backlog to ToDo in DAM Sprint Apr 3, 2019
@lolli42 lolli42 moved this from ToDo to In Progress in DAM Sprint Apr 4, 2019
@lolli42
Copy link
Contributor

lolli42 commented Apr 4, 2019

yeah. our fileExists strategy does not work here since fal does not sanitize identifiers internally, but the identifier is created client side without being properly sanitized when uploading / testing for existance. we'll have to rewrite both methods to do that properly ourselfs on server side.

@lolli42 lolli42 moved this from In Progress to In Review in DAM Sprint Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
DAM Sprint
  
In Review
Development

No branches or pull requests

2 participants