Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of items is not working in list view #116

Open
benjaminkott opened this issue Apr 8, 2019 · 1 comment
Open

Selection of items is not working in list view #116

benjaminkott opened this issue Apr 8, 2019 · 1 comment
Labels

Comments

@benjaminkott
Copy link
Member

benjaminkott commented Apr 8, 2019

Description

  • The select all checkbox has no effect in the list view and triggers a js error
    TypeError: Cannot read property 'length' of undefined
  • The select toggle for a row has no effect in the list view and triggers a js error
    TypeError: Cannot read property 'includes' of undefined
  • The markup for select toggles is list view is not rendered as intended

Markup

<span class="component-checkbox">
    <input type="checkbox" id="component-datatable-select-j6klvj" value="1" class="component-checkbox-input">
    <label for="component-datatable-select-j6klvj" class="component-checkbox-label">
        <span class="component-visually-hidden">select NAME</span>
    </label>
</span>
@benjaminkott
Copy link
Member Author

Related: #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant