Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dir-index-html to v1.2.0 #846

Closed
wants to merge 2 commits into from

Conversation

WhiteEgg
Copy link
Contributor

@WhiteEgg WhiteEgg commented Dec 9, 2020

Update dir-index-html to v1.2.0
Update upstream url
TRON-US/dir-index-html#4

@TronJenkinsBot
Copy link
Collaborator

Can one of the admins verify this patch?

@taiyangc
Copy link
Contributor

taiyangc commented Dec 9, 2020

ok to test

@taiyangc
Copy link
Contributor

taiyangc commented Dec 9, 2020

@WhiteEgg One of the tests failed, please try to run make test locally.

@WhiteEgg
Copy link
Contributor Author

WhiteEgg commented Dec 9, 2020

@taiyangc
issue is https://github.com/TRON-US/go-btfs/blob/master/core/corehttp/gateway_test.go#L482
test output:
<strong> Index of /btns/<a href="/btns/example.net">example.net</a> </strong>
ipfs/dir-index-html#42 looks upstream issue
fix in ipfs/kubo#7699 and ipfs/dir-index-html#43
merge patch or skip test?

@taiyangc
Copy link
Contributor

taiyangc commented Dec 9, 2020

@WhiteEgg ok to apply patch as long as it's not bringing other module upgrades?

@WhiteEgg WhiteEgg marked this pull request as draft December 10, 2020 06:12
@WhiteEgg
Copy link
Contributor Author

WhiteEgg commented Dec 11, 2020

Yeah, only upgrade dir-index-html and go-btfs, but may have some other issues, test not work in 34b7e35, i try use upstream in go-btfs but not work same, then i test go-ipfs v0.7.0 it's work

@taiyangc
Copy link
Contributor

Hmm maybe it's a test more complicated to modify than just name changes...

@WhiteEgg
Copy link
Contributor Author

WhiteEgg commented Dec 11, 2020

But... ipfs/kubo@2feff33 i think it just want to show Index of /btfs/$Qmhash not Index of / ? try to find more issues

@laipogo
Copy link
Contributor

laipogo commented Mar 23, 2021

Thank you, @WhiteEgg
We will fix this test in next release.

@laipogo laipogo closed this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants