Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing after connection lost leads to exception spam #24

Open
T1mmos opened this issue Jan 6, 2021 · 0 comments
Open

Resizing after connection lost leads to exception spam #24

T1mmos opened this issue Jan 6, 2021 · 0 comments
Assignees

Comments

@T1mmos
Copy link
Owner

T1mmos commented Jan 6, 2021

When the server closes, the client shows a disconnected dialog (good).
However when resizing the frame, exception spam occurs.
Seems that the GamePanelManager is not cleared and is still requested to return its rescale requests. The question is: should it be nullified, reset? Can we resize the scalable components? If yes, we should support rescaling when State.Game == null. If the scalable components cannot be reused, we don't have anything to show, so rescaling would not make sense.

@T1mmos T1mmos self-assigned this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant