Change order number to Order relation on Refund #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Enhancement
Zales0123
force-pushed
the
relate-refund-with-order
branch
from
583bf7f
to
119dee3
Compare
AdamKasp
approved these changes
Jun 8, 2021
GSadee
approved these changes
Jun 9, 2021
|
Thank you, Mateusz! 🥇 |
Zales0123
added a commit
that referenced
this pull request
Jun 10, 2021
…efundPayment (GSadee) This PR was merged into the 1.0-dev branch. Discussion ---------- Partially fixes #193 Similar to #306 Commits ------- 91173ec [RefundPayment] Change order number to Order relation on RefundPayment eee327c [RefundPayment] Add migration for changing the order relation d278a5d [RefundPayment] Add note in UPGRADE file about changing the order relation 545d719 [Behat] Fix FailedRefundPaymentFactory after changing the order relation 8a526ab [RefundPayment] Fixes after static analysis f464e20 [RefundPayment] Adjust DefaultRelatedPaymentIdProvider after changing the order relation 371a21c [RefundPayment] Adjust routing and twig after changing the order relation 4b25791 [RefundPayment] Introduce custom repository
GSadee
added a commit
to Sylius/InvoicingPlugin
that referenced
this pull request
Jun 14, 2021
This PR was merged into the 1.0-dev branch. Discussion ---------- Similar to Sylius/RefundPlugin#306 and Sylius/RefundPlugin#307. Should be easier to operate on the Invoice with a proper relation rather than just an order number Commits ------- 081b080 Add Order relation on Invoice (and remove order number field) e480edc Use order instead of order number in invoice repository 0ab7fed Final fixes ce949d3 Mention changes in the UPGRADE file 8411c18 Remove unneeded point in UPGRADE file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #193
Time has shown, such a low coupling was not the best approach from the technical and DX point of view. We still have time to change it, before the stable release, so let's do it :) If in the future we decide it's reasonable to lose this coupling (and we can justify it and implement it properly), it would be easier to be done without major BC breaks 🖖 🚀