[Pdf] set translation credit memo locale #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKasp
reviewed
Jan 28, 2021
| @@ -32,7 +32,7 @@ | |||
| <img src="https://demo.sylius.com/assets/shop/img/logo.png" style="width:300px;"> | |||
| </td> | |||
| <td> | |||
| {{ 'sylius_refund.ui.issued_at'|trans }}: {{ creditMemo.issuedAt|date('Y-m-d H:i:s') }}<br> | |||
| {{ 'sylius_refund.ui.issued_at'|trans([], 'messages', creditMemo.localeCode) }}: {{ creditMemo.issuedAt|date('Y-m-d H:i:s') }}<br> | |||
There was a problem hiding this comment.
What do you think about extraction this creditMemo.localeCode to a variable, instead of copying it 17 times :D?
There was a problem hiding this comment.
i dont think if it makes any difference :D this way we know every translation gets credit memo locale code.
pamil
approved these changes
Jan 28, 2021
GSadee
approved these changes
Jan 29, 2021
SirDomin
force-pushed
the
fix-translation-pdf-credit-memo
branch
from
e3e19b7
to
668ed50
Compare
|
Thank you, @SirDomin! 🥇 |
diimpp
reviewed
Jan 29, 2021
| @@ -32,7 +32,7 @@ | |||
| <img src="https://demo.sylius.com/assets/shop/img/logo.png" style="width:300px;"> | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #229
Admin panel locale: fr_FR, pdf is printed in english (credit memo locale)
