Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Refund float price #234

Merged
merged 1 commit into from
Dec 22, 2020
Merged

[UI/UX] Refund float price #234

merged 1 commit into from
Dec 22, 2020

Conversation

TheGrimmChester
Copy link
Contributor

Use number type field instead of the text type.
The web browser will send the value formatted correctly if we use 8.5 or 8,5.
Right now on master if we put 8,5, only 8.0 is refunded but with this fix, the decimals seperated by comma are taken into account.

@TheGrimmChester TheGrimmChester requested a review from a team as a code owner December 9, 2020 10:30
@diimpp
Copy link
Member

diimpp commented Dec 9, 2020

It's possible to specify min/max over there as well. What do you think? Works alright on my project.

Copy link
Member

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible improvement add 0 to min value.

@GSadee GSadee merged commit f053acc into Sylius:master Dec 22, 2020
@GSadee
Copy link
Member

GSadee commented Dec 22, 2020

Thank you, Nicolas! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants