[Maintenance] phpstan upgrade #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafikooo
force-pushed
the
SYL-2542/phpstan-upgrade
branch
from
6f23c55
to
eda7d75
Compare
jakubtobiasz
requested changes
Dec 21, 2022
Rafikooo
force-pushed
the
SYL-2542/phpstan-upgrade
branch
2 times, most recently
from
68ddd8e
to
f0f8018
Compare
NoResponseMate
approved these changes
Dec 21, 2022
Rafikooo
force-pushed
the
SYL-2542/phpstan-upgrade
branch
from
f0f8018
to
c84bef1
Compare
Rafikooo
force-pushed
the
SYL-2542/phpstan-upgrade
branch
from
c84bef1
to
6079093
Compare
jakubtobiasz
approved these changes
Dec 22, 2022
|
Thank you, Rafał! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we moved to
phpstan ^1.xversion across Sylius it would be good to do it here as well