Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] PHP Attributes introduced #303

Merged
merged 1 commit into from
Dec 22, 2022
Merged

[Maintenance] PHP Attributes introduced #303

merged 1 commit into from
Dec 22, 2022

Conversation

Rafikooo
Copy link
Contributor

Since we do not use PHP 7.4 anymore, it's preferable to support both annotations and attributes with the default annotations setting 🎉

@Rafikooo Rafikooo added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Dec 14, 2022
@Rafikooo Rafikooo requested a review from a team as a code owner December 14, 2022 15:30
@jakubtobiasz jakubtobiasz merged commit 1dd7d14 into Sylius:main Dec 22, 2022
@jakubtobiasz
Copy link
Contributor

Thanks, Rafał! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rafikooo @jakubtobiasz