Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Remove wkhtmltopdf binary #300

Merged
merged 2 commits into from
Nov 21, 2022
Merged

[Maintenance] Remove wkhtmltopdf binary #300

merged 2 commits into from
Nov 21, 2022

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Nov 17, 2022

Let's remove the binary from the repo and install it in the GitHub Actions.

@coldic3 coldic3 requested a review from a team as a code owner November 17, 2022 16:33
@coldic3 coldic3 added Maintenance Configurations, READMEs, releases, etc. DX Issues and PRs aimed at improving Developer eXperience. labels Nov 18, 2022
@GSadee GSadee merged commit a5980e1 into Sylius:main Nov 21, 2022
@GSadee
Copy link
Member

GSadee commented Nov 21, 2022

Thank you, Kevin! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coldic3 @GSadee