feat(client): update the template cards #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2387. Update the template cards on the new project page.
leafty
temporarily deployed
to
renku-ci-ui-2999
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-2999.dev.renku.ch |
leafty
temporarily deployed
to
renku-ci-ui-2999
GitHub Actions
Inactive
leafty
had a problem deploying
to
renku-ci-ui-2999
GitHub Actions
Failure
leafty
had a problem deploying
to
renku-ci-ui-2999
GitHub Actions
Failure
leafty
had a problem deploying
to
renku-ci-ui-2999
GitHub Actions
Failure
leafty
temporarily deployed
to
renku-ci-ui-2999
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-2999
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-2999
GitHub Actions
Inactive
lorenzo-cavazzi
requested changes
Jan 26, 2024
There was a problem hiding this comment.
The code looks good- okay, I admit I had to read it twice to understand why there are so many CardBody 😂
I feel the hover/selected styling collides a little too much making the UX sub-optimal when using the mouse. Not sure how easy it would be to improve it -- I suggest a possible solution inline
client/src/components/templateSelector/TemplateSelector.module.scss
Outdated
Show resolved
Hide resolved
leafty
had a problem deploying
to
renku-ci-ui-2999
GitHub Actions
Error
leafty
temporarily deployed
to
renku-ci-ui-2999
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-2999
GitHub Actions
Inactive
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2387.
Update the template cards on the new project page.
/deploy