Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): fix DOM nesting error for the loader spinner #2750

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix(client): fix DOM nesting error for the loader spinner #2750

merged 2 commits into from
Aug 21, 2023

Conversation

leafty
Copy link
Member

@leafty leafty commented Aug 18, 2023 •
edited
Loading

Fixes a small DOM error for the loader spinner when it is inserted in <p> elements:

Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

The spinner now uses <span> when inline is set to true.

There is no visual change introduced.

@leafty leafty marked this pull request as ready for review August 18, 2023 09:17
@leafty leafty requested a review from a team as a code owner August 18, 2023 09:17
@leafty leafty merged commit 38c7ac8 into master Aug 21, 2023
13 checks passed
@leafty leafty deleted the leafty/fix-loader-spinner branch August 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leafty @lorenzo-cavazzi