Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): HPA for reverse proxy #643

Merged
merged 1 commit into from
Apr 20, 2023
Merged

fix(chart): HPA for reverse proxy #643

merged 1 commit into from
Apr 20, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented Apr 20, 2023

The templating for the horizontal pod autoscaler was using a mix of apiVersion v1 and v2.

Now we use v2 and v2beta2 which are idential in terms of what we use from them and this covers any k8s version older than 1.12.

/deploy #persist extra-values=gateway.reverseProxy.autoscaling.enabled=true

@olevski olevski requested a review from a team as a code owner April 20, 2023 14:33
@olevski olevski requested a review from aledegano April 20, 2023 14:33
@olevski olevski deployed to renku-ci-gw-643 April 20, 2023 14:33 — with GitHub Actions Active
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-gw-643.dev.renku.ch

targetAverageUtilization: {{ .Values.reverseProxy.autoscaling.targetCPUUtilizationPercentage }}
target:
type: Utilization
averageUtilization: {{ .Values.reverseProxy.autoscaling.targetCPUUtilizationPercentage }}
{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@olevski olevski merged commit de11c52 into master Apr 20, 2023
@olevski olevski deleted the fix-hpa-helm-revproxy branch April 20, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants