Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Can/Should Element insert(child:) be renamed to add(child:) #13

Open
jessegrosjean opened this issue Jul 1, 2021 · 0 comments
Open

Comments

@jessegrosjean
Copy link
Contributor

Is there a reason why this method isn't named add?

public func insert(child node: Node) {
    xmlAddChild(xmlNode, node.xmlNode)
}

The underlying API uses the term 'add'. To me insert means the method should take an index, or maybe the node will be put in the front of the children list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant