Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash and Corrupted File #78

Closed
maxoakland opened this issue Aug 3, 2022 · 5 comments
Closed

Crash and Corrupted File #78

maxoakland opened this issue Aug 3, 2022 · 5 comments

Comments

@maxoakland
Copy link

maxoakland commented Aug 3, 2022

While I was working on a song, Huge crashed. It said it backed up the file but the file is apparently corrupted because Huge will no longer open it and crashes when it tries to play it

The crash error:
Screen Shot 2022-08-03 at 4 28 50 PM

The errors opening the file:
image
(of course I extracted it)

Error when trying to play the song:
image

@SuperDisk
Copy link
Owner

Hi, could you attach the module file?

@maxoakland
Copy link
Author

Hi, could you attach the module file?

Here you go
Akira Track 01-2.uge.zip

@SuperDisk
Copy link
Owner

The song isn't actually corrupted, it's just that you've somehow inserted some invalid notes into it. How did you make this song? Was it imported from somewhere, or copy/pasted from OpenMPT, or something? If you scroll through the song, you'll see a few places where there's ??? in place of a note-- that's an invalid note code.

If you remove these, then the song will be valid again, but it's then it's too big to fit in one bank since there's a huge amount of unique patterns.

@maxoakland
Copy link
Author

maxoakland commented Aug 9, 2022

The song isn't actually corrupted, it's just that you've somehow inserted some invalid notes into it. How did you make this song? Was it imported from somewhere, or copy/pasted from OpenMPT, or something? If you scroll through the song, you'll see a few places where there's ??? in place of a note-- that's an invalid note code.

If you remove these, then the song will be valid again, but it's then it's too big to fit in one bank since there's a huge amount of unique patterns.

This is the track I was copying and pasting from Famitracker

After some very slow searching I see the ???. Can you make it so they turn up red? I found it really hard to see them because they’re so close to the background color

Also the warning that comes up should be more descriptive and probably shouldn’t crash the application if you can help it

Also, thanks for taking a look at this. I’ve gone over the whole file several times but it’s still not playing even though all the ? marks are gone

@SuperDisk
Copy link
Owner

I added a safety guard in 07f720a which clamps any FamiTracker note to a valid range, so at minimum there shouldn't be any more ??? appearing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants