Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync footstep audio #2177

Merged
merged 41 commits into from
Oct 20, 2024
Merged

Sync footstep audio #2177

merged 41 commits into from
Oct 20, 2024
+215 −13

Commits on Aug 28, 2024

  1. Created packet and processors for footstep audio(not functional at al… 

    …l yet)
    @OhmV-IR
    OhmV-IR committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    d4e3ff2 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. prototype client-side footstep packet processing

    @OhmV-IR
    OhmV-IR committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    7e0c624 View commit details
    Browse the repository at this point in the history

  2. Switch to using player's AnimationController to find velocity

    @OhmV-IR
    OhmV-IR committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    380d9ba View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Footstep packets are forwarded from server to players within hearing … 

    …range(20f)
    @OhmV-IR
    OhmV-IR committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e07a5c3 View commit details
    Browse the repository at this point in the history

  2. Fixed FootstepPacket class to fit format(was crashing)

    @OhmV-IR
    OhmV-IR committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    180bb35 View commit details
    Browse the repository at this point in the history

  3. Removed duplicate var

    @OhmV-IR
    OhmV-IR committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    26db96c View commit details
    Browse the repository at this point in the history

  4. cleanup

    @OhmV-IR
    OhmV-IR committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a772c16 View commit details
    Browse the repository at this point in the history

  5. Added transpiler to send packets when local client plays footstep sou… 

    …nd(TYSM for the help Jannify)

Co-authored-by: Jannify <24827220+Jannify@users.noreply.github.com>
    @OhmV-IR
    OhmV-IR committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    eaf1122 View commit details
    Browse the repository at this point in the history

  6. Lower volume of other players' footsteps(suggested by NinjaPedroX)

    @OhmV-IR
    OhmV-IR committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a879656 View commit details
    Browse the repository at this point in the history

  7. Added same structure/submarine check for sending footstep packet to o… 

    …ther player
    @OhmV-IR
    OhmV-IR committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    8ef9842 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Removed logs

    @OhmV-IR
    OhmV-IR committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    092af16 View commit details
    Browse the repository at this point in the history

  2. Formatting changes

    @OhmV-IR
    OhmV-IR committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    c6814b3 View commit details
    Browse the repository at this point in the history

  3. Formatting changes

    @OhmV-IR
    OhmV-IR committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    737028e View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Newline changes

    @OhmV-IR
    OhmV-IR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    103c14e View commit details
    Browse the repository at this point in the history

  2. newline changes

    @OhmV-IR
    OhmV-IR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5a5fc18 View commit details
    Browse the repository at this point in the history

  3. Split long line into shorter lines 

    Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
    @OhmV-IR @Jannify
    OhmV-IR and Jannify authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    91936ec View commit details
    Browse the repository at this point in the history

  4. Remove unneeded this keyword 

    Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
    @OhmV-IR @Jannify
    OhmV-IR and Jannify authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6545583 View commit details
    Browse the repository at this point in the history

  5. Applying suggestions from Jannify's review 

    Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
    @OhmV-IR
    OhmV-IR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    33d249c View commit details
    Browse the repository at this point in the history

  6. Merge

    @OhmV-IR
    OhmV-IR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8cc0956 View commit details
    Browse the repository at this point in the history

  7. Added comment in packet processors to keep values updated, trying to … 

    …implement fetching the value from .csv file
    @OhmV-IR
    OhmV-IR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c1d0ef3 View commit details
    Browse the repository at this point in the history

  8. Pull sound range from .csv file(UNTESTED)

    @OhmV-IR
    OhmV-IR committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c4c851f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Add whitespace 

    Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
    @OhmV-IR @Jannify
    OhmV-IR and Jannify authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    756bece View commit details
    Browse the repository at this point in the history

  2. Add whitespace 

    Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
    @OhmV-IR @Jannify
    OhmV-IR and Jannify authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    30055b8 View commit details
    Browse the repository at this point in the history

  3. Merged ifs and removed var type usage

    @OhmV-IR
    OhmV-IR committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d26a186 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'sync-footstep-audio' of https://github.com/OhmV-IR/Nitr… 

    …oxModdedUnofficial into sync-footstep-audio
    @OhmV-IR
    OhmV-IR committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5c6f971 View commit details
    Browse the repository at this point in the history

  5. Merged else + if into else if

    @OhmV-IR
    OhmV-IR committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    38c6161 View commit details
    Browse the repository at this point in the history

  6. Inverted if with early return condition

    @OhmV-IR
    OhmV-IR committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9a5927b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Compare subroot IDs using .Equals instead of 2 if statements

    @OhmV-IR
    OhmV-IR committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    38c1aa7 View commit details
    Browse the repository at this point in the history

  2. Overriding .Equals in Optional<> for consistency and performance 

    Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
    @OhmV-IR
    OhmV-IR committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6d4dcbf View commit details
    Browse the repository at this point in the history

  3. Merged 2 if statements & fixed bad clause

    @OhmV-IR
    OhmV-IR committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bef5717 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Fixed bug(was getting all players instead of only connected ones)

    @OhmV-IR
    OhmV-IR committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7e56f40 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Changed names of StepSound enum members 

    Co-authored-by: tornac1234 <tortornac@gmail.com>
    @OhmV-IR @tornac1234
    OhmV-IR and tornac1234 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    76c9b07 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. removed unneeded this keyword 

    Co-authored-by: tornac1234 <tortornac@gmail.com>
    @OhmV-IR
    OhmV-IR committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2bd2d9d View commit details
    Browse the repository at this point in the history

  2. Reordered and cleaned usings 

    Co-authored-by: tornac1234 <tortornac@gmail.com>
    @OhmV-IR
    OhmV-IR committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7d81eaa View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Did sort and clean usings with correct setting 

    Co-authored-by: tornac1234 <tortornac@gmail.com>
    @OhmV-IR
    OhmV-IR committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5b17e1f View commit details
    Browse the repository at this point in the history

  2. added extra if check

    @OhmV-IR
    OhmV-IR committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4d70262 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Change number of added instructions in test class 

    Co-authored-by: tornac1234 <tortornac@gmail.com>
    @OhmV-IR @tornac1234
    OhmV-IR and tornac1234 committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    80b4006 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. equality methods can be used by systems depending on the IEquatable a… 

    …bstraction

Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
    @OhmV-IR @Jannify
    OhmV-IR and Jannify committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    33b5201 View commit details
    Browse the repository at this point in the history

  2. Inverted if statement 

    Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
    @OhmV-IR @Jannify
    OhmV-IR and Jannify committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    22e8113 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Updated sound levels 

    Co-authored-by: gussandst <160942469+gussandst@users.noreply.github.com>
Co-authored-by: WerewolfsX <160942469+WerewolfsX@users.noreply.github.com>
    @OhmV-IR @gussandst
    3 people committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5a4b34a View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Change references of exosuit steps asset path to land asset path 

    Co-authored-by: tornac1234 <tortornac@gmail.com>
    @OhmV-IR @tornac1234
    OhmV-IR and tornac1234 committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    7f2b288 View commit details
    Browse the repository at this point in the history