Improved grant local admin to allow all IPs that will loop back #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API tests that the IP address points to the same machine that is executing the code (localhost).
Previously this only worked for 127.x.x.x range IPs but now also works for LAN ipv4 and ipv6 IPs.
Measurity
force-pushed
the
grant-local-admin
branch
from
1980201
to
c2627f9
Compare
dartasen
approved these changes
Jul 2, 2023
Coding-Hen
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this only worked for 127.x.x.x range IPs but now also works for LAN ipv4 and ipv6 IPs.