-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MainMenu Controller support #2055
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I'm new here, but I've been reading PRs to get an idea of how this mod is developed. Feel free to take my advice with a grain of salt.
Do we want this in for 1.8 ? |
Also it's now controller friendly
This re-enables controller support
a0c0f46
to
9038864
Compare
onClick.RemoveAllListeners() doesn't remove all listeners, see https://docs.unity3d.com/ScriptReference/Events.UnityEventBase.RemoveAllListeners.html
…eScope() is called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently when we click on a server (to join it) and click on another menu (e.g. Play, Multiplayer) while connecting to the server (first step which is notably long when trying to connect to a server that is not started) there's a loading panel appearing which ends up opening an "unable to connect" panel when failing. But this will still open even if we opened another menu in the meantime. For example if we open options while connecting to a server, when we get the fail message, the menu will try to switch to the multiplayer panel but fail and will leave an empty screen.
A fix for this would to cut connection when exiting the loading tab while connecting to a server.
Also I had some issues while selecting the color picker for some reason, some times it work pretty well, but some times it didn't.
NitroxPatcher/Patches/Persistent/SystemsSpawner_SetupSingleton_Patch.cs
Outdated
Show resolved
Hide resolved
NitroxClient/MonoBehaviours/Gui/MainMenu/ServersList/MainMenuServerListPanel.cs
Outdated
Show resolved
Hide resolved
NitroxClient/MonoBehaviours/Gui/MainMenu/ServersList/MainMenuServerListPanel.cs
Outdated
Show resolved
Hide resolved
NitroxClient/MonoBehaviours/Gui/MainMenu/ServerJoin/JoinServerBackend.cs
Outdated
Show resolved
Hide resolved
NitroxClient/MonoBehaviours/Gui/MainMenu/ServerJoin/JoinServerBackend.cs
Outdated
Show resolved
Hide resolved
7af82d0
to
8306604
Compare
8306604
to
4a037fe
Compare
UI looks better overall Legend :
Few suggestions about the UX, leaving that here I don't know how painful is it to do with the code-behind unity API :
About the UI :
|
159ce5a
to
499f6e6
Compare
Partial-Completes #1653
Closes #1816