Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reducing allocations and error handling improvements #2040

Merged
merged 5 commits into from
May 22, 2023
Merged

Reducing allocations and error handling improvements #2040

merged 5 commits into from
May 22, 2023

Commits on May 15, 2023

  1. Removed closure captures in NatHelper.cs

    @Measurity
    Measurity committed May 15, 2023
    Configuration menu
    Copy the full SHA
    45f1ed2 View commit details
    Browse the repository at this point in the history

  2. Reduced byte array allocations when packets are received

    @Measurity
    Measurity committed May 15, 2023
    Configuration menu
    Copy the full SHA
    620a1f0 View commit details
    Browse the repository at this point in the history

  3. Added error handling for NatHelper.AddPortMappingAsync() 

    Added more context to error messages when port forwarding fails
    @Measurity
    Measurity committed May 15, 2023
    Configuration menu
    Copy the full SHA
    9cb0da7 View commit details
    Browse the repository at this point in the history

  4. Removed compiled flag in regex for parsing IP from site content 

    The compiled flag slows things down unnecessarily since the regex is not used many times.
    @Measurity
    Measurity committed May 15, 2023
    Configuration menu
    Copy the full SHA
    9dd0da8 View commit details
    Browse the repository at this point in the history

  5. Removed unused variable in GameSettings_SerializeInputSettings_Patch

    @Measurity
    Measurity committed May 15, 2023
    Configuration menu
    Copy the full SHA
    57dfce1 View commit details
    Browse the repository at this point in the history