Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd:resize] conflict with the bootstrap.js #2019

Closed
Nuvolect opened this issue May 23, 2017 · 12 comments
Closed

[cmd:resize] conflict with the bootstrap.js #2019

Nuvolect opened this issue May 23, 2017 · 12 comments
Assignees
Labels

Comments

@Nuvolect
Copy link

When selecting an image, and the command Resize & Rotate, the dialog box no longer appears. The REST interface is quiet. It does not ask for a "file", "dim" or any command at all. Resize worked properly with this connector in earlier versions.

The API 2.1 document states:

To be able to resize the image, cdc record file must be specified and resize dim. resize must be in true dim and contain a line with dimensions of height and width (like "600x400"). If specified without resize dim resize the dialog will not work correctly.

There is no reference to "cdc record file" in the documentation. It is unclear what this is. Just guessing but it appears that earlier version of elFinder relied on the "dim" property of a file object. The object file provided includes a dim property with the accurate dimensions.

Guidance appreciated.

@nao-pon
Copy link
Member

nao-pon commented May 24, 2017

@Nuvolect The description about "cdc - dim" in the document is API 1, so API 2.0 or later is not necessary. I deleted the description earlier.

Which connector do you use?

@Nuvolect
Copy link
Author

@nao-pon
Copy link
Member

nao-pon commented May 24, 2017

No request is made by XHR at the time the resize dialog is opened. Is there a JavaScript error?

@Nuvolect
Copy link
Author

Good call:

Uncaught TypeError: Cannot read property 'classes' of undefined
at String. (https://10.0.1.2:8002/js/jquery-ui.min.js:8:11128)
at Function.each (https://10.0.1.2:8002/js/jquery-3.1.1.min.js:2:2865)
at t.(anonymous function).(anonymous function)._resolveClassesValues (https://10.0.1.2:8002/js/jquery-ui.min.js:8:11094)
at t.(anonymous function).(anonymous function)._resolveClassesValues (https://10.0.1.2:8002/js/jquery-ui.min.js:6:4499)
at HTMLButtonElement. (https://10.0.1.2:8002/js/jquery-ui.min.js:8:9373)
at Function.each (https://10.0.1.2:8002/js/jquery-3.1.1.min.js:2:2815)
at r.fn.init.each (https://10.0.1.2:8002/js/jquery-3.1.1.min.js:2:1003)
at String. (https://10.0.1.2:8002/js/jquery-ui.min.js:8:9205)
at Function.each (https://10.0.1.2:8002/js/jquery-3.1.1.min.js:2:2865)
at t.(anonymous function).(anonymous function)._initWidgets (https://10.0.1.2:8002/js/jquery-ui.min.js:8:8750)
(anonymous) @ jquery-ui.min.js:8
each @ jquery-3.1.1.min.js:2
_resolveClassesValues @ jquery-ui.min.js:8
(anonymous) @ jquery-ui.min.js:6
(anonymous) @ jquery-ui.min.js:8
each @ jquery-3.1.1.min.js:2
each @ jquery-3.1.1.min.js:2
(anonymous) @ jquery-ui.min.js:8
each @ jquery-3.1.1.min.js:2
_initWidgets @ jquery-ui.min.js:8
(anonymous) @ jquery-ui.min.js:6
refresh @ jquery-ui.min.js:8
(anonymous) @ jquery-ui.min.js:6
_enhance @ jquery-ui.min.js:8
(anonymous) @ jquery-ui.min.js:6
_create @ jquery-ui.min.js:8
(anonymous) @ jquery-ui.min.js:6
_createWidget @ jquery-ui.min.js:6
t.(anonymous function).(anonymous function) @ jquery-ui.min.js:6
(anonymous) @ jquery-ui.min.js:6
each @ jquery-3.1.1.min.js:2
each @ jquery-3.1.1.min.js:2
t.fn.(anonymous function) @ jquery-ui.min.js:6
open @ elfinder.full.js:23352
exec @ elfinder.full.js:23482
(anonymous) @ elfinder.full.js:10796
(anonymous) @ elfinder.full.js:10456
dispatch @ jquery-3.1.1.min.js:3
q.handle @ jquery-3.1.1.min.js:3

@Nuvolect
Copy link
Author

I bumped jquery to 3.2.1 from 3.1.1 but no difference.
Image preview pop-up works fine.

@Nuvolect
Copy link
Author

It fails in Chrome, Safari and Firefox. Here is the error in Firefox:
screen shot 2017-05-24 at 11 05 25 am

@nao-pon
Copy link
Member

nao-pon commented May 24, 2017

What about using jQueryUI 1.12.1?

@Nuvolect
Copy link
Author

Looks like the same error:

screen shot 2017-05-24 at 12 25 49 pm

@nao-pon
Copy link
Member

nao-pon commented May 25, 2017

Not jQuery 1.12.1, JQueryUI 1.12.1.

Or, Have you loading any other JavaScript libraries?

@Nuvolect
Copy link
Author

OK, JQueryUI 1.12.1 is now being loaded, same error.

List of all JS libraries:
<script src="/js/jquery-3.2.1.min.js"></script>
<script src="/js/jquery-ui.min.js"></script>
<script src="js/elfinder.full.js"></script>
<script src="/js/angular.min.js"></script>
<script src="/js/bootstrap.min.js"></script>

screen shot 2017-05-25 at 1 19 41 pm

@nao-pon
Copy link
Member

nao-pon commented May 26, 2017

This is caused by conflicts with the bootstrap. Since there are similar issues in the past, I'll take measures on the elFinder side.

rel. #740, #1398, #1620

@nao-pon nao-pon changed the title Resize Dialog Not Opening [cmd:resize] conflict with the bootstrap.js May 26, 2017
@nao-pon nao-pon self-assigned this May 26, 2017
@nao-pon
Copy link
Member

nao-pon commented May 26, 2017

@Nuvolect Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants