only check trackable on children

SteveSanderson · Jun 12, 2015 · 240cb84 · 240cb84
1 parent 08a7974
commit 240cb84
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/dist/knockout-es5.js b/dist/knockout-es5.js
@@ -83,7 +83,7 @@
   }
 
   function wrap(obj, props, deep) {
-    if (!props.length || !canTrack(obj)) {
+    if (!props.length) {
       return;
     }
 
@@ -127,7 +127,11 @@
         notifyWhenPresentOrFutureArrayValuesMutate(ko, observable);
 
         if (deep) {
-          origValue.forEach(function (child) { wrap(child, Object.keys(child), true); });
+          origValue.forEach(function (child) {
+            if (canTrack(child)) {
+              wrap(child, Object.keys(child), true); 
+            }
+          });
         }
       } else if (deep && canTrack(origValue)) {
         wrap(origValue, Object.keys(origValue), true);

diff --git a/dist/knockout-es5.min.js b/dist/knockout-es5.min.js
diff --git a/src/knockout-es5.js b/src/knockout-es5.js
@@ -83,7 +83,7 @@
   }
 
   function wrap(obj, props, deep) {
-    if (!props.length || !canTrack(obj)) {
+    if (!props.length) {
       return;
     }
 
@@ -127,7 +127,11 @@
         notifyWhenPresentOrFutureArrayValuesMutate(ko, observable);
 
         if (deep) {
-          origValue.forEach(function (child) { wrap(child, Object.keys(child), true); });
+          origValue.forEach(function (child) {
+            if (canTrack(child)) {
+              wrap(child, Object.keys(child), true); 
+            }
+          });
         }
       } else if (deep && canTrack(origValue)) {
         wrap(origValue, Object.keys(origValue), true);