Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetCurrentAuthenticationTicket() should not mutate DB state #74

Open
mtornwall opened this issue Nov 5, 2018 · 0 comments
Open

GetCurrentAuthenticationTicket() should not mutate DB state #74

mtornwall opened this issue Nov 5, 2018 · 0 comments
Assignees
@habib535
Labels
enhancement important

Comments

@mtornwall
Copy link
Contributor

AuthenticationTicketService.GetCurrentAuthenticationTicket() should not mutate database state. Currently it deletes expired tickets and extends the expiry time. This quickly turns bad if an app (reasonably) assumes idempotency of GetCurrentAuthenticationTicket() and calls it during view model dirty checking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@habib535 habib535

Labels
enhancement important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@warpech @mtornwall @habib535 @joozek78