ext.uls.displaysettings: Update class name #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! |
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions-UniversalLanguageSelector
that referenced
this pull request
Mar 10, 2022
I suspect these may have been accidentally mixed up or miscompleted from a nearly data-attribute or interface message, since all other classes start with `.uls-` in this repository. * "uls-input-settings-imes" is not used referenced anywhere else. * "uls-sub-panel" is referenced in one skinStyles override, updated with StarCitizenTools/mediawiki-skins-Citizen#434. Change-Id: Ia0b23d795f7807ef9227f66d0890a25524cd5a9f
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions
that referenced
this pull request
Mar 10, 2022
* Update UniversalLanguageSelector from branch 'master'
to af6084894250c5669fb47e9bb768c45262ff9527
- displaysettings,inputsettings: Rename two classes for consistency
I suspect these may have been accidentally mixed up or miscompleted
from a nearly data-attribute or interface message, since all other
classes start with `.uls-` in this repository.
* "uls-input-settings-imes" is not used referenced anywhere else.
* "uls-sub-panel" is referenced in one skinStyles override, updated with
StarCitizenTools/mediawiki-skins-Citizen#434.
Change-Id: Ia0b23d795f7807ef9227f66d0890a25524cd5a9f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://gerrit.wikimedia.org/r/768220.