Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transparent Youtube Logo #90

Closed
wants to merge 2 commits into from
Closed

Transparent Youtube Logo #90

wants to merge 2 commits into from

Conversation

abhijit360
Copy link

PR Checklist

Overview

I found an online transparent svg and then used a tool online to change the colour #3A5A6E. The svg is transparent. However the colour isn't being appled for some reason

JoshuaKGoldberg
JoshuaKGoldberg requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this branch just has the package-lock.json addition, but not the actual YouTube logo itself?

I'd recommend reading through https://github.com/SquiggleTools/SquiggleConf/blob/main/.github/DEVELOPMENT.md to help with getting set up locally using pnpm. I'm guessing you're running npm install (or npm i for short), which isn't quite right for this repo.

Thanks! ✨

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Jul 23, 2024
@JoshuaKGoldberg
Copy link
Member

[done ] Addresses an existing open issue:

P.s. This should be [x], not [done ]. It's an actual GitHub feature: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 23, 2024
Closed
@JoshuaKGoldberg
Copy link
Member

👋 @abhijit360 do you still have energy + time to work on this?

@abhijit360
Copy link
Author

Yes! I will have the PR's in this week.

@JoshuaKGoldberg
Copy link
Member

(talked offline: may have time later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg requested changes

Assignees
No one assigned
Labels
status: waiting for author Needs an action taken by the original poster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Find a truly transparent YouTube svg
2 participants
@abhijit360 @JoshuaKGoldberg