Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DamageEntityPostEvent #2374

Open
Lucavon opened this issue Jul 10, 2021 · 0 comments
Open

DamageEntityPostEvent #2374

Lucavon opened this issue Jul 10, 2021 · 0 comments
Labels
status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage

Comments

@Lucavon
Copy link

Lucavon commented Jul 10, 2021

Hello!

We currently don't have a DamageEntityPostEvent, making it very difficult to react to damage after it happens. For example, if you were to apply a piece of armor to someone using the DamageEntityEvent, the armor would be factored into the calculation and take damage, too. For this reason, we need a DamageEntityPostEvent. Here's a list of attributes it would need to have:

  • Damaged entity
  • Original damage before anything was changed
  • Base Damage
  • Final damage
  • Whether a modifier was applicable (basically isApplicable())
  • List of modifiers
  • Whether it caused death
  • Damage source

If I forgot any attributes, feel free to add them!
@limbo-app limbo-app added the status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lucavon @limbo-app