-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup for ImGuiFileDialog extension #89
Conversation
Hi! I believe you're getting the error cause u don't have a flatten files structure. The "dirent" folder is a part of the subrepo, so its path is "ImGuiFileDialog/dirent/dirent.h". When the compiler expects "dirent/dirent.h". To fix it, you need to add a path to the folder in the GenerateLibs script (as you did for the module itself). |
Thanks for the tip @SpaiR, that got the include working. I am running into a linker error, not fully sure what the issue is, but I have not torn it apart yet. I would like your thoughts on the PaneFun callback. I looked at the existing callbacks, and implemented something similar. But I then realized that I will have an issue with having multiple of the callbacks defined, which is a (highly likely) possibility. Perhaps you have an idea on implementing it that will be consistent with the rest of the code base. I can hack something together for it, but I am trying to keep my coding style consistent with yours. The hashmap return on the I am pulling the documentation directly from the ImGuiFileDialog code, but I am correcting a couple spelling mistakes that I am finding. Some of the API is well documented, and those parts are the main functions in the API. For now I will implement those. There are other less documented functions, I am not 100% sure how those work at the moment, but they do not seem critical to how the library functions, mostly for just styling. I may decide to implement those at a later date and just stay focused on the core functionality if that is OK. Anyways, I would like to know your thoughts and feedback. Thanks, EDIT: Some of the jni callback code is not compiling. I will strip it out and commit a compiling version to show the linker error. |
…, seems that some header is being included multiple times.
@SpaiR I think I have this ready to go, can you review it? |
@tlf30 Very clean PR! Thank you for your contribution. I'll do a release with your additions in the near future for sure. |
@SpaiR the one thing I realize I forgot was to update the README.md to add it to the extensions list. Perhaps when you cut the next release you can add it, or I can open another PR for it. |
@tlf30 I would appreciate it if you would do that. |
Hello @SpaiR,
I would like to add support for the extension ImGuiFileDialog: https://github.com/aiekick/ImGuiFileDialog
I have got an initial start on it, and wanted to make sure I was headed in the right direction before I got too far into it. It looks like this should be straightforward to add, but I am seeing this error during the build:
Anyways, I would love to know your thoughts.
Thanks,
Trevor